Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CLI errors handling. #591

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Improve CLI errors handling. #591

merged 4 commits into from
Feb 23, 2024

Conversation

shimkiv
Copy link
Member

@shimkiv shimkiv commented Feb 22, 2024

Closes #568

@shimkiv shimkiv added the bug Something isn't working label Feb 22, 2024
@shimkiv shimkiv self-assigned this Feb 22, 2024
@shimkiv shimkiv mentioned this pull request Feb 22, 2024
Open
MartinMinkov
MartinMinkov reviewed Feb 22, 2024
View reviewed changes
src/bin/index.js Outdated Show resolved Hide resolved
ymekuria
ymekuria approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@ymekuria ymekuria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @shimkiv! I tested this out with different invalid commands and it works well.

@shimkiv shimkiv merged commit 7eb0660 into main Feb 23, 2024
12 checks passed
@shimkiv shimkiv deleted the feat/invalid-commands-hdlr branch February 23, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barriebyron barriebyron barriebyron left review comments

@MartinMinkov MartinMinkov MartinMinkov left review comments

@ymekuria ymekuria ymekuria approved these changes

@mitschabaude mitschabaude Awaiting requested review from mitschabaude

@Trivo25 Trivo25 Awaiting requested review from Trivo25

Assignees

@shimkiv shimkiv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Improve error messages for invalid commands
4 participants
@shimkiv @ymekuria @MartinMinkov @barriebyron